Counter visualization enhancements #4392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added Sum/Min/Max - changed visualisation -> visualization for consistence with the rest
* Counter enhancements * Code style * Allow to deselect column; don't migrate options for new visualizations; minor fixes * Secondary values editor: disable input when secondary value not available * Use row data (if available) when formatting values and tooltips * Show secondary value controls only visibility - don't disable inputs * Mve round baces around secondary value to format templates * Fix options migration bug * Render counter only if some data available * Ability to disable secondary value; place Show Secondary Value checkbox after other options * Format hints * Fix options migration bug * Tests: getCounterData * Tests: Editor * Code style * Tests: Renderer * Tests: Renderer (unit-tests) * Fix unit tests hanging on CI * CR1
gabrieldutra
changed the title
|
This PR is now holding all recent updates (great part of them made by @kravets-levko's efforts) to the Counter Visualization 😬:
@arikfr I noticed the existence of #2942, if you think that's a quick win and that's still relevant it should be a good time to do it. |
|
@gabrieldutra , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts? We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR will allow more aggregation types for the Counter Visualization.
So far I just started exploring it, I wanted to have the types definition centered in one place and also it makes sense to merge the existing
countRows. Currently I centered that logic in utils because it's where the current counter logic is, but I'll later see a better place to that.One thing that I'll need to see is what's the best way of handling backward compatibility for the
countRows, I was thinking a migration as it would just define Types for existing counters, though I haven't done a migration on my own yet so just confirming that 😅.To do:
Related Tickets & Documents
Closes #4366
Closes #2558
Mobile & Desktop Screenshots/Recordings (if there are UI changes)