add an option 'Skip TLS verification' to Elasticsearch query runnner #4416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyakelp
force-pushed
the
skip_es_tls_verification
branch
from
ec2126c to
925373e
Compare
miyakelp
force-pushed
the
skip_es_tls_verification
branch
from
925373e to
2933047
Compare
|
@arikfr - Can this conflict be fixed? We are running ES with TLS and we need to leverage this feature. |
|
Hi, do we have this feature merged for redash 9 beta version.? I am facing the same issue as #2791 |
miyakelp
force-pushed
the
skip_es_tls_verification
branch
from
be43168 to
430d38c
Compare
|
@miyakelp , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts? We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add support for Elasticsearch using self signed certificate.
If skip TLS verification is enabled, set verify option of requests.get as False.
Related Tickets & Document
#2791
Mobile & Desktop Screenshots/Recordings (if there are UI changes)