Migrate Query Source page to React: Visualization actions #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return Visualization.delete({ id: visualization.id }) | ||
| .$promise.then(() => { | ||
| const filteredVisualizations = filter(query.visualizations, v => v.id !== visualization.id); | ||
| return Promise.resolve(extend(clone(query), { visualizations: filteredVisualizations })); |
There was a problem hiding this comment.
While working on #4468 I realized that _.clone is not enough to properly clone query instance, so I added a .clone() method to Query service. No need to fix it in this PR, but we should keep this in mind and fix in one of subsequent PRs
kravets-levko
added a commit
that referenced
this pull request
Jan 6, 2020
* Migrate Query Source View page to React: skeleton * Sync QueryView and QuerySource (#4430) * Migrate schema browser to react (#4432) * Restyle code with Prettier * Migrate Query page to React: Save changes (#4452) * Migrate query source to React: Set of updates (#4457) * Migrate Query page to React: Visualization Tabs (#4453) Co-Authored-By: Levko Kravets <levko.ne@gmail.com> * Migrate Query Source page to React: Visualizations area (#4463) * Migrate Query page to React: Delete visualization button (#4461) * Migrate Query Source page to React: Visualization actions (#4467) * Migrate Query pages to React: Execute query hook (#4470) * Migrate Query Source page to React: Editor area (#4468) * Migrate Query Source page to React: metadata, schedule and description blocks (#4476) * Migrate Query page to React: Cancel query execution (#4496) * Migrate Query Source page to React: refine code (#4499) * Migrate Query Source page to React: alerts (#4504) * Migrate Query Source page to React: unsaved changes alert (#4505) * Migrate Query Source to React: resizable areas (v2) (#4503) * Migrate Query page to React: Query View (#4455) Co-authored-by: Levko Kravets <levko.ne@gmail.com> * Switch React and Angular versions of pages (until Angular version removed) * Migrate Query pages to React: fix permissions (#4506) * Migrate Query Source page to React: don't reload when saving new query (#4507) * Migrate Query pages to React: fix tests (#4509) * Use skipParametersDirtyFlag in executeQuery * Fix: cannot fork query from Query View page * Optimize query editor: handle query text changes faster * Revert "Optimize query editor: handle query text changes faster" This reverts commit 2934e53. * Reduce debounced time to 100 * Migrate Query pages to React: cleanup (#4512) * Migrate Query pages to React: cleanup * Further cleanup * Remove unused dependencies * Fix embed pages * Attempt to fix flaky test * Cleanup: explicitly register the last Angular component * Move contents of /filters folder to /lib * Remove unnecessary import * Remove cy.wait from Parameters spec Co-authored-by: Gabriel Dutra <nesk.frz@gmail.com> Co-authored-by: Levko Kravets <levko.ne@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
@kravets-levko lmk your opinion about this option for those actions, since they are shared. Also took the opportunity to remove the
forceUpdateusage by updating the query state.(Code in QuerySource is more an example and not necessarily needs to go now)
Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--