Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cypress issues after React version of Query Pages #4545

Merged
merged 2 commits into from
Jan 20, 2020

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Other

Description

After the React version of the query pages, a couple of specs started to show some flakyness. I decided to investigate, since it could be related to a real issue, so this PR has two fixes:

  • Pivot Spec: for some reason the .pvtGrandTotal was pointing a different value in Cypress, and in the screenshot it looked ok... I assumed it was just a different way of rendering that caused it, so I changed the assertion method;
  • Parmeter Spec: this one is a real issue and deserves a small discussion: previously to the React Migration of the query pages we used to allow the user to Re-execute a query while it's running when parameters are changed. This can cause overflow on queries execution since the user can trigger a query multiple times. On the other hand, it can also be annoying when you trigger a query with wrong parameters and has to wait for it to finish.

Related Tickets & Documents

--

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

--

@arikfr
Copy link
Member

arikfr commented Jan 14, 2020

  • his one is a real issue and deserves a small discussion: previously to the React Migration of the query pages we used to allow the user to Re-execute a query while it's running when parameters are changed.

this is no longer possible?

@gabrieldutra
Copy link
Member Author

this is no longer possible?

I forgot to mention what I did 😅. This PR makes it possible as it was before the migration (I preferred to keep the behavior users have). Basically: if a query is running, you can't trigger it again with the Execute button, but you can with the Apply Changes button.

Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arikfr arikfr merged commit 086798b into master Jan 20, 2020
@arikfr arikfr deleted the cypress-react-query-pages-issues branch January 20, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants