Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counter: tooltip format setting #4596

Closed
wants to merge 6 commits into from
Closed

Counter: tooltip format setting #4596

wants to merge 6 commits into from

Conversation

kravets-levko
Copy link
Collaborator

@kravets-levko kravets-levko commented Jan 28, 2020 •
edited
Loading

What type of PR is this? (check all applicable)

  • Feature

Description

Counter visualization has a hidden setting for value tooltip format (applied to counter and target value if they're numbers). This PR adds ability to edit this setting in editor.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image

@kravets-levko kravets-levko self-assigned this Jan 28, 2020
@kravets-levko kravets-levko changed the title Counter: tooltip format setting (WIP) Counter: tooltip format setting Jan 28, 2020
@kravets-levko kravets-levko changed the title (WIP) Counter: tooltip format setting Counter: tooltip format setting Jan 28, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
arikfr
arikfr reviewed Feb 3, 2020
View reviewed changes
Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels wrong that the tooltip uses a different configuration method than the other numbers for the same visualization. We need to be consistent.

What will it take to convert the configuration for the value/target to use the string format?

@kravets-levko
Copy link
Collaborator Author

What will it take to convert the configuration for the value/target to use the string format?

Do you mean value/target tooltips or value/target themselves?

@arikfr
Copy link
Member

arikfr commented Feb 3, 2020

What will it take to convert the configuration for the value/target to use the string format?

Do you mean value/target tooltips or value/target themselves?

Themselves.

@kravets-levko
Copy link
Collaborator Author

I think one day at most, but it will require migration (and I may need some assistance with it)

@arikfr
Copy link
Member

arikfr commented Feb 3, 2020

Can't we just translate old options into new string in runtime?

@kravets-levko
Copy link
Collaborator Author

Can't we just translate old options into new string in runtime?

That's possible. I think I'll implement it and update this PR to include this feature.

@kravets-levko kravets-levko changed the title Counter: tooltip format setting (WIP) Counter: tooltip format setting Feb 4, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 10, 2020
Closed
@kravets-levko kravets-levko mentioned this pull request Feb 18, 2020
Closed
@kravets-levko kravets-levko changed the title (WIP) Counter: tooltip format setting Counter: tooltip format setting Feb 26, 2020
@kravets-levko
Copy link
Collaborator Author

Replaced by #4642

@guidopetri guidopetri deleted the counter-tooltip-format branch July 22, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr arikfr left review comments

@gabrieldutra gabrieldutra Awaiting requested review from gabrieldutra

Assignees

@kravets-levko kravets-levko

Labels
Frontend Visualizations: Counter Visualizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kravets-levko @arikfr