Cypress tests for Query Based Parameters Mapping UI #4685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldutra
force-pushed
the
query-based-dropdown--parameters-tests
branch
from
b2c28ba to
4e3eea2
Compare
gabrieldutra
force-pushed
the
query-based-dropdown--parameters-tests
branch
from
4e3eea2 to
80229dc
Compare
|
@gabrieldutra , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts? We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that. |
|
This PR is part of a matched pair with #4648. Lets close this one only if/when we've decided what to do with that other one. 😄 |
|
@gabrieldutra What're your thoughts on the PR that goes with this one (#4648)? Should that one be closed too, or something else? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Cypress tests for #4648 (opening a new PR for an easier review).
I split
parameter_spec.jsbecause it was too large already (f2d23ae). The tests are in 5b7aa31.Related Tickets & Documents
#4648
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--