Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress: Separate start command and update to v4.1.0 #4690

Merged
merged 3 commits into from
Mar 11, 2020

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Other

Description

This separates npm run cypress build and npm run cypress start (also automatically seeds database in here as this is usually done anyway, skipable with --skip-db-seed).

Related Tickets & Documents

--

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

--

@kravets-levko
Copy link
Collaborator

Just an idea: cypress:start does some extra job, so it makes sense to keep it; but looks that other commands are just wrappers for docker-compose with specified project name (-p cypress). So what if there'll be just a single command that will run docker-compose -p cypress ${args}? Use case: for me it's quite annoying that Cypress container is re-built every time I cypress:start it (it's because cypress:stop destroys container). With such command I'll be able to choose the action - stop or down. WDYT?

@gabrieldutra
Copy link
Member Author

I don't know 😅, then it starts to be just easier to run the docker-compose -p cypress. The reason to have a down command instead was mostly to clean test data afterwards and have a quick set of commands within this purpose. Also the time consuming part of the start command is in the db creation and data seed (the container creation seems quite fast).

@gabrieldutra gabrieldutra force-pushed the cypress-separate-commands branch from 002307a to 7659b30 Compare February 27, 2020 19:48
@gabrieldutra gabrieldutra changed the title Cypress: Separate build and start commands Cypress: Separate start command and update to v4.1.0 Mar 1, 2020
@gabrieldutra
Copy link
Member Author

gabrieldutra commented Mar 1, 2020

@kravets-levko I also updated Cypress to v4.1.0 (didn't need to change ath, just the version on package.json). Do you have any other quick wins in mind or let's merge this?

Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gabrieldutra gabrieldutra merged commit f4b69d4 into master Mar 11, 2020
@gabrieldutra gabrieldutra deleted the cypress-separate-commands branch March 11, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants