Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix google create user with long profile pic url #4941

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fsr313
Copy link
Contributor

@fsr313 fsr313 commented Jun 4, 2020

What type of PR is this? (check all applicable)

  • Bug Fix

Description

when creating a new user using google, the image url can be bigger of what the model accepts (320). the error is handled and the model object updated and fixed so it can be commited to the database.
tests, for this were added as well

Related Tickets & Documents

#4469

@fsr313 fsr313 changed the title Fix 4469 fix google create user with long profile pic url Jun 4, 2020
@fsr313 fsr313 closed this Jun 4, 2020
@fsr313 fsr313 reopened this Jun 4, 2020
@luislizarraga
Copy link

If you know what the issue is, it would be better to address it directly instead of relying on Exceptions, as the DataError could be triggered by any number of things and not just because the profile picture URL is too long.

@tim5go
Copy link
Contributor

tim5go commented Sep 24, 2020

@fsr313 @luislizarraga
Can we make it as simple as:
if len(user_object._profile_image_url) > 320: user_object._profile_image_url = None
rather than throwing DataError

@guidopetri
Copy link
Contributor

@fsr313 , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

@justinclift
Copy link
Member

The concept of this PR sounds like it could be useful.

But looking over the code and the review/suggestion by @luislizarraga, it seems like it needs to be implemented differently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants