Textbox: confirm close if text was changed #5009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kravets-levko
force-pushed
the
textbox-confirm-close
branch
2 times, most recently
from
a4d8353 to
79c2277
Compare
kravets-levko
force-pushed
the
textbox-confirm-close
branch
from
79c2277 to
898a002
Compare
|
Thank you @gabrieldutra! I'm not good in texting 😅
|
Co-authored-by: Gabriel Dutra <nesk.frz@gmail.com>
gabrieldutra
approved these changes
Jun 29, 2020
andrewdever
pushed a commit
to andrewdever/redash
that referenced
this pull request
Oct 5, 2020
* Textbox: confirm close if text was changed * Update texting (with @gabrieldutra) * Update texting Co-authored-by: Gabriel Dutra <nesk.frz@gmail.com> Co-authored-by: Gabriel Dutra <nesk.frz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When adding or editing a textbox it's very easy to accidentally close the dialog and lose all changes (by clicking outside of dialog). This PR solves this issue by showing a confirmation dialog when trying to close a textbox dialog with changes.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)