Fix Databricks Schema Browser scrollbar #5023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kravets-levko
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Issue: Double scrollbox on SchemaBrowser (the
.schema-browserhad an extra scrollbar)This PR fixes the DB SchemaBrowser scrollbar by moving the border definition to an external wrapper as it seems the
AutoSizerdoesn't work that well when the parent has a border and creates an overflow.I also took the opportunity and removed the scrollbar from the
.schema-browsersince after we update that component, it is the AutoSizer the one that contains the scroll.Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before
2 scroll areas were created
After
Only one scroll area remaining -> the one from AutoSizer