Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Add TypeScript infra based on babel preset #5042

Closed
wants to merge 3 commits into from

Conversation

benamorbe
Copy link
Contributor

@benamorbe benamorbe commented Jul 10, 2020

What type of PR is this? (check all applicable)

This PR is a POC on adding TypeScript via babel preset instead of ts-loader. The main benefits of using babel/TypeScript combinations:

  1. We have 1 compiler/loader instead of 2 separate compilers/loaders.
  2. We can use all features of babel! We already have it in Redash!
  3. Almost instant compile during development loop! ts-loader is very slow.
  4. Check for type errors only when you’re ready. Babel won't compile all TypeScript when we make changes. It simply strips TypeScript. Once you are sure about your experimental code, you can fix the types.
  5. Out of the box support for @babel/preset-env in TypeScript for better ES/browsers targeting.
  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@benamorbe benamorbe changed the title Add TypeScript infra based on babel preset [POC] Add TypeScript infra based on babel preset Jul 10, 2020
@arikfr
Copy link
Member

arikfr commented Jul 16, 2020

Closing this as changes were added to #5027.

@arikfr arikfr closed this Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants