Databricks Schema Browser: Allow eventlet worker instead of RQ #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldutra
force-pushed
the
db-schema-browser--improve-timing
branch
from
d1fdadb to
0f14712
Compare
arikfr
reviewed
Jul 14, 2020
| } | ||
| return axios | ||
| .get(`api/databricks/databases/${id}`, { params }) | ||
| .then(data => (has(data, "job.id") ? fetchDataFromJob(data.job.id, 300).catch(() => []) : data)); |
There was a problem hiding this comment.
We still call fetchDataFromJob to make it easier to switch to RQ in the future?
There was a problem hiding this comment.
The idea was on those lines, but I can actually remove it for now :)
gabrieldutra
changed the title
Co-authored-by: Arik Fraimovich <arik@arikfr.com>
gabrieldutra
commented
Jul 14, 2020
Comment on lines
+111
to
+115
| - run: | ||
| name: "Failure: output container logs to console" | ||
| command: | | ||
| docker-compose logs | ||
| when: on_fail |
There was a problem hiding this comment.
This part is because I had to debug when it failed. It's good to keep anyway.
|
👍 |
andrewdever
pushed a commit
to andrewdever/redash
that referenced
this pull request
Oct 5, 2020
…dash#5045) * Add loading button in UI * Handle databricks schema requests without RQ * Don't use gevent worker * Revert "Don't use gevent worker" This reverts commit 9704c70. * Use eventlet * Use first column instead of 'namespace' one * Revert "Add loading button in UI" This reverts commit c0e4dfb. * Remove databricks tasks * Update eventlet * Add libevent * Display logs on failure * Revert "Add libevent" This reverts commit a00d067. * Test updating gunicorn * Don't set eventlet as the default for Redash Co-authored-by: Arik Fraimovich <arik@arikfr.com> * Remove fetchDataFromJob usage Co-authored-by: Arik Fraimovich <arik@arikfr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Use eventlet worker in order to make the Databricks Schema Browser more responsive.
Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--