-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Query Runner: Apache Pinot #5446
Conversation
Hi @kravets-levko , has this been abandoned? |
e3fba24
to
d5543ba
Compare
oh, wow, I almost forgot about this one: it's been almost a year) |
Hey @justrp and @etadelta222 thanks so much for the ping. We just introduced our new process for reviews which includes a new PR template you can see here. Would you mind updating the PR description? Really all we need to see is the applicable versions of pinot for which this query runner will work. I'm looking forward to getting this reviewed and merged ASAP! |
"FLOAT": TYPE_FLOAT, | ||
"DOUBLE": TYPE_FLOAT, | ||
"STRING": TYPE_STRING, | ||
"BYTES": TYPE_STRING, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add more types here, especially the TIMESTAMP
@@ -42,3 +42,4 @@ xlrd==2.0.1 | |||
openpyxl==3.0.7 | |||
firebolt-sdk | |||
pandas==1.3.4 | |||
pinotdb==0.3.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.3.11 is the latest version :p
Hi @susodapop , is the information provided by Xiangfu sufficient? |
in case if you wait for me to address these changes - unfortunately, can't provide clear ETA - got a very busy time now :( |
What type of PR is this? (check all applicable)
Description
Query runner for http://pinot.apache.org/
Related Tickets & Documents
apache/pinot#6297
Mobile & Desktop Screenshots/Recordings (if there are UI changes)