Update Azure Data Explorer query runner to latest version #7209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacentropy
force-pushed
the
upd-azure-kusto-4
branch
from
e577bdd
to
77d4969
Compare
arikfr
reviewed
Oct 29, 2024
redash/query_runner/azure_kusto.py
Outdated
| if msi: | ||
| kcsb = KustoConnectionStringBuilder.with_aad_managed_service_identity_authentication(cluster) | ||
| # Specific user assigned Managed Service Identity | ||
| elif msi and self.configuration["user_msi"]: |
There was a problem hiding this comment.
I think this won't be called because if msi is True then it will always stop with the first if. You need to have this come before the plain if msi:.
| ) | ||
| # Service Principal auth | ||
| else: | ||
| kcsb = KustoConnectionStringBuilder.with_aad_application_key_authentication( |
There was a problem hiding this comment.
Now that this is optional in case msi is True we should confirm that all 3 fields have values in this case.
spacentropy
force-pushed
the
upd-azure-kusto-4
branch
from
77d4969
to
cc6c9f3
Compare
spacentropy
force-pushed
the
upd-azure-kusto-4
branch
from
cc6c9f3
to
bd08f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Hello. Here's the list of things that were improved:
How is this tested?