Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelpDrawer “Open in New Window” button WIP #250

Closed
wants to merge 1 commit into from
Closed

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Jun 5, 2019

@ranbena ranbena self-assigned this Jun 5, 2019
@ranbena ranbena force-pushed the open-win branch 2 times, most recently from 0877815 to 56c4e39 Compare June 5, 2019 23:26
@ranbena
Copy link
Contributor Author

ranbena commented Jun 6, 2019

@arikfr I just realized that the current design's dependency on getredash/redash#3880 makes it impractical cause previous Redash versions would present this unacceptable UX problem.

Screen Shot 2019-06-05 at 17 53 14

So, 2 options ahead of us:

  1. Find an alternative design that can work with such a large button. Here's something that can work but I don't love it.

  1. Fallback to option 1 in the discussion.

@gabrieldutra
Copy link
Member

gabrieldutra commented Jun 6, 2019

Perhaps you can use a new class selector introduced in the dependency PR instead of .drawer for body:not(.drawer) ? This way it will appear only for the new code.

@ranbena
Copy link
Contributor Author

ranbena commented Jun 7, 2019

Perhaps you can use a new class selector introduced in the dependency PR instead of .drawer for body:not(.drawer) ? This way it will appear only for the new code.

That's a great idea!
But deep inside I know this is the wrong approach and implementing option 2 won't be such a hassle.

@ranbena
Copy link
Contributor Author

ranbena commented Jun 8, 2019

Perhaps you can use a new class selector introduced in the dependency PR instead of .drawer for body:not(.drawer) ? This way it will appear only for the new code.

Actually @gabrieldutra I'm not sure how that would have worked. The .drawer classname doesn't come from the parent window but from within the website (determined by window.parent !== window).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants