fix: Uninstall iOS signal handler after one invocation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
approved these changes
Mar 2, 2021
Swatinem
added a commit
that referenced
this pull request
Apr 12, 2021
supervacuus
pushed a commit
to supervacuus/breakpad
that referenced
this pull request
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Priviously, the signal handler of iOS would not terminate the process or delegate to the original signal handler, which at least in the iOS simulator would lead to an infinite signal loop and start writing a huge amount of minidumps. By restoring the signal handlers to the original, only one minidump is written and the default signal handlers are invoked.