feat: powershell target #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR is still a draft (a.k.a not ready for review) and the unrelated stuff will be split out + I hope to add tests if I can figure it out. Currently I'm testing it manually and trying to fix unrelated issues with zip file download |
|
Thanks @vaind for raising this! |
|
@asottile-sentry please let me know if we need any other change to get this through |
asottile-sentry
approved these changes
Mar 11, 2024
|
Thx. Can you please merge as well? I don't have permissions
…On Mon, 11 Mar 2024, 16:48 anthony sottile, ***@***.***> wrote:
***@***.**** approved this pull request.
apologies I was out sick the last week and change (still am) but going to
approve to unblock
<https://camo.githubusercontent.com/85f8965a2c34def7000687646fdb65c472209133f6a378e918530f73be868109/68747470733a2f2f692e666c756666792e63632f71487a66634236425a395a44374b3377466b6e714c737248717371353662504d2e676966>
—
Reply to this email directly, view it on GitHub
<#515 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQOG4QBUNQUHKIS4WJDW2DYXXN5ZAVCNFSM6AAAAABD2NCFBGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRYGIYTMOJUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks @vaind and @asottile-sentry ! |
|
@asottile-sentry hope u get well soon 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds powershell publishing support