Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(errors): Improving the error msgs for dependency errors #101

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

IanWoodard
Copy link
Member

Fixes #96

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (460ab07) to head (deca957).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/exceptions.py 55.55% 4 Missing ⚠️
devservices/commands/start.py 50.00% 2 Missing ⚠️
devservices/commands/stop.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   91.10%   90.19%   -0.91%     
==========================================
  Files          16       16              
  Lines         708      724      +16     
==========================================
+ Hits          645      653       +8     
- Misses         63       71       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hubertdeng123 hubertdeng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do any tests here need to be updated to be more thorough?

@IanWoodard IanWoodard merged commit 3c6ee57 into main Nov 1, 2024
12 of 14 checks passed
@IanWoodard IanWoodard deleted the iw/improved-dependency-error-msg branch November 1, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add better error message for dependency errors
2 participants