Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): Limit log length and check to ensure service is running before printing logs #114

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

hubertdeng123
Copy link
Member

This limits the amount of logs that are printed to console. It also fixes a bug where logs can be printed despite a service is not running if a dependency of the service is running.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (ef2aa5e) to head (3f072e8).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   90.53%   90.54%   +0.01%     
==========================================
  Files          19       19              
  Lines         824      825       +1     
==========================================
+ Hits          746      747       +1     
  Misses         78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hubertdeng123 hubertdeng123 merged commit 363e12a into main Nov 1, 2024
13 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/logs-fixes branch November 1, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants