Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start): Add threading and condition to wait for containers to be healthy #144

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Nov 13, 2024

This adds multithreading for docker compose commands and waits for containers to pass healthchecks before exiting

@hubertdeng123 hubertdeng123 changed the base branch from main to hubertdeng123/multi-thread-run-docker-compose November 13, 2024 23:37
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.36%. Comparing base (9da0c84) to head (c4c74ba).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/utils/docker_compose.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   90.31%   90.36%   +0.05%     
==========================================
  Files          20       20              
  Lines         960      965       +5     
==========================================
+ Hits          867      872       +5     
  Misses         93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hubertdeng123 hubertdeng123 changed the title feat(start): Add condition to ensure containers are healthy when starting feat(start): Add threading and condition to wait for containers to be healthy Nov 14, 2024
@hubertdeng123 hubertdeng123 changed the base branch from hubertdeng123/multi-thread-run-docker-compose to main November 14, 2024 00:45
@hubertdeng123 hubertdeng123 merged commit 57e42a0 into main Nov 14, 2024
11 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/wait-healthcheck-start branch November 14, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants