Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(up): Restart services when switching modes #160

Merged
merged 9 commits into from
Nov 21, 2024
Merged

Conversation

IanWoodard
Copy link
Member

Currently, there is a bug where if you bring a service up in a certain mode, then bring it up in a different mode, there not only could be extraneous dependencies left running, but also the internal state does not update meaning bringing the service back down will likely not work correctly. As a short term fix for this, we opted to check the current running mode and the desired mode and if they differ, but for the same service, we restart the service and bring it up in the desired mode. Longer term we plan on making the logic more intelligent and able to only bring up and down what is necessary to make it faster and more efficient.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.67%. Comparing base (c022882) to head (8f6f1b1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/commands/up.py 71.42% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   90.61%   90.67%   +0.05%     
==========================================
  Files          20       20              
  Lines        1076     1104      +28     
==========================================
+ Hits          975     1001      +26     
- Misses        101      103       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devservices/commands/up.py Show resolved Hide resolved
devservices/commands/up.py Outdated Show resolved Hide resolved
devservices/commands/up.py Outdated Show resolved Hide resolved
@IanWoodard IanWoodard merged commit dfe43f0 into main Nov 21, 2024
13 of 14 checks passed
@IanWoodard IanWoodard deleted the iw/restart-mode branch November 21, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants