fix(sentry): Do not report to sentry if service is not found #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 90.66% 91.44% +0.77%
==========================================
Files 21 22 +1
Lines 1253 1297 +44
==========================================
+ Hits 1136 1186 +50
+ Misses 117 111 -6 ☔ View full report in Codecov by Sentry. |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: devservices/commands/up.py
Did you find this useful? React with a 👍 or 👎 |
hubertdeng123
commented
Dec 2, 2024
| @@ -32,10 +32,13 @@ def list_dependencies(args: Namespace) -> None: | |||
|
|
|||
| try: | |||
| service = find_matching_service(service_name) | |||
| except (ConfigError, ServiceNotFoundError) as e: | |||
| except ConfigError as e: | |||
There was a problem hiding this comment.
I also think we want to avoid reporting ConfigNotFoundError too, thoughts?
IanWoodard
approved these changes
Dec 3, 2024
hubertdeng123
deleted the
hubertdeng123/do-not-report-error-service-not-found
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional noise, so let's not report to sentry if ServiceNotFound error is raised