Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(modes): Refactoring modes to support multiple concurrent modes #173

Merged
merged 10 commits into from
Dec 6, 2024

Conversation

IanWoodard
Copy link
Member

Currently, we only support bringing up a service in a single mode at a time. After discussing it further with the team, we concluded that it would make more sense to allow users to run multiple modes simultaneously and to not have bringing up a sub-mode resulting in dependencies being brought down.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (a722118) to head (c387f25).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   91.45%   91.99%   +0.53%     
==========================================
  Files          22       22              
  Lines        1299     1286      -13     
==========================================
- Hits         1188     1183       -5     
+ Misses        111      103       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from iw/fix-dep-graph-construction to main December 6, 2024 18:22
@IanWoodard IanWoodard merged commit 34f6adc into main Dec 6, 2024
11 checks passed
@IanWoodard IanWoodard deleted the iw/mode-refactor branch December 6, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants