fix(purge): Updating purge to stop/remove all devservices containers #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 22 22
Lines 1470 1470
=======================================
Hits 1365 1365
Misses 105 105 ☔ View full report in Codecov by Sentry. |
hubertdeng123
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only stop/remove running devservices containers during purge which means there is an edge case where problematic containers are not running and thus are not removed by purge. This can lead to issues such as "network not found" errors when starting up.
https://getsentry.atlassian.net/browse/DEVINFRA-565