Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(docker-compose): refactoring docker compose util #48

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

IanWoodard
Copy link
Member

Found a way to abstract away a bunch of duplicate code by letting the run_docker_compose_command utility to automatically add -p and -f using the service info.

@IanWoodard IanWoodard merged commit 42e9d6f into main Sep 27, 2024
12 checks passed
@IanWoodard IanWoodard deleted the iw/docker-compose-refactor branch September 27, 2024 23:47
Copy link

sentry-io bot commented Oct 1, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AttributeError: 'CompletedProcess' object has no attribute 'split' list-services View Issue
  • ‼️ TypeError: 'CompletedProcess' object is not subscriptable ls View Issue
  • ‼️ DockerComposeError list-services View Issue
  • ‼️ FileNotFoundError: [Errno 2] No such file or directory: 'docker' start View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants