Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependency): Adding dependency management to commands #56

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

IanWoodard
Copy link
Member

Adding the first layer of dependency management to commands. This includes pulling in one level of remote dependencies for services. What this means is that when running start, we first find and install any required remote dependencies for the given service. All other commands that rely on docker compose first check to see if the dependencies exist locally (as they should) since we want to re-use the same dependencies we installed/updated when we ran start. There are potential edge-cases where the service may have been started but the dependencies don't exist locally (not sure how this would happen yet, but it's likely possible). In this case, we have a basic fallback to simply re-install the dependencies, which while not ideal, since the dependencies could have been updated since running start, it is a good initial mitigation effort that we can further improve down the road.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.23%. Comparing base (07f0eca) to head (f7536b9).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/utils/docker_compose.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   84.11%   86.23%   +2.12%     
==========================================
  Files          11       11              
  Lines         321      356      +35     
==========================================
+ Hits          270      307      +37     
+ Misses         51       49       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanWoodard IanWoodard merged commit bb63316 into main Oct 3, 2024
14 checks passed
@IanWoodard IanWoodard deleted the iw/dependency-management-ext branch October 3, 2024 17:45
Copy link

sentry-io bot commented Oct 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ DockerComposeVersionError: Docker compose version unsupported, please upgrade to >= 2.29.0 devservices.utils.docker_compose in check_docke... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants