Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Pin docker compose version for users #68

Merged

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Oct 8, 2024

This pins docker compose as a user plugin for docker for version 2.29.7 for our users. That way, we have full control over docker compose behavior

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (7c1cff4) to head (15a7f86).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   88.40%   90.46%   +2.06%     
==========================================
  Files          12       12              
  Lines         414      514     +100     
==========================================
+ Hits          366      465      +99     
- Misses         48       49       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hubertdeng123 hubertdeng123 changed the title pin docker compose version for docker user plugin ref: Pin docker compose version for users Oct 15, 2024
@hubertdeng123 hubertdeng123 marked this pull request as ready for review October 15, 2024 05:00
Copy link
Member

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial comments. Overall this is looking good though, works well locally

devservices/exceptions.py Outdated Show resolved Hide resolved
devservices/utils/docker_compose.py Outdated Show resolved Hide resolved
devservices/utils/docker_compose.py Show resolved Hide resolved
devservices/utils/docker_compose.py Outdated Show resolved Hide resolved
devservices/utils/docker_compose.py Outdated Show resolved Hide resolved
devservices/utils/docker_compose.py Outdated Show resolved Hide resolved
@hubertdeng123 hubertdeng123 merged commit f8f36df into main Oct 17, 2024
14 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/pin-user-docker-compose-plugin-version branch October 17, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants