Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(dependencies): Providing information about installed remote dependencies after installing #82

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

IanWoodard
Copy link
Member

To enable us to properly manage start and stop (as well as other commands) with nested dependencies, we need to know what nested service dependencies we need to start/stop separately and what dependencies may be shared between services.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.01%. Comparing base (e5e907b) to head (74ff319).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/utils/dependencies.py 93.75% 2 Missing ⚠️
devservices/utils/docker_compose.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   90.90%   91.01%   +0.10%     
==========================================
  Files          16       16              
  Lines         649      679      +30     
==========================================
+ Hits          590      618      +28     
- Misses         59       61       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanWoodard IanWoodard merged commit aa59c00 into main Oct 23, 2024
14 checks passed
@IanWoodard IanWoodard deleted the iw/service-names-exp branch October 23, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants