Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devservices): Run commands for nested dependencies by project #86

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Oct 24, 2024

This adds support for running docker commands for nested remote dependencies. Each docker compose command is run with its own appropriate service name as its project.

For example:

Grandparent (grandparent-service)
--> Parent (parent-service)
----> Child (child-service-1, child-service-2)

Docker Compose projects:
Grandparent:

  • grandparent-service

Parent:

  • parent-service

Child:

  • child-service-1
  • child-service-2

Copy link

sentry-io bot commented Oct 24, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: devservices/utils/docker_compose.py

Function Unhandled Issue
check_docker_compose_version DockerComposeInstallationError: Failed to install Docker Compose: Failed to move docker-compose binary to /Users/robertcarp/.dock... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.08%. Comparing base (aa59c00) to head (ff7cb67).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
devservices/utils/docker_compose.py 91.42% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   91.01%   91.08%   +0.07%     
==========================================
  Files          16       16              
  Lines         679      707      +28     
==========================================
+ Hits          618      644      +26     
- Misses         61       63       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanWoodard IanWoodard marked this pull request as ready for review October 24, 2024 22:28
@hubertdeng123 hubertdeng123 merged commit 88f2654 into main Oct 28, 2024
14 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/nested_run_docker_compose_command branch October 28, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants