Move GitHubOrg (and GitHubConfig) out of @/config #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2023
|
|
||
| // Config - loosely typed and ephemeral, used for collecting values found in | ||
| // Don't use '@api' here, because it's ... not loaded yet, or something? |
There was a problem hiding this comment.
😮 What error is being thrown here?
There was a problem hiding this comment.
$ yarn test -- src/config/loadGitHubOrgsFromEnvironment.test.ts
Error: Jest: Got error running globalSetup - /Users/chadwhitacre/workbench/getsentry/eng-pipes/test/jest.glo
balSetup.ts, reason: Your application tried to access @api/github, but it isn't declared in your dependencie
s; this makes the require call ambiguous and unsound.
Required package: @api/github (via "@api/github/org")
Required by: /Users/chadwhitacre/workbench/getsentry/eng-pipes/src/config/
Require stack:
- /Users/chadwhitacre/workbench/getsentry/eng-pipes/src/config/loadGitHubOrgsFromEnvironment.ts
- /Users/chadwhitacre/workbench/getsentry/eng-pipes/src/config/index.ts
- /Users/chadwhitacre/workbench/getsentry/eng-pipes/src/knexfile.ts
- /Users/chadwhitacre/workbench/getsentry/eng-pipes/test/jest.globalSetup.ts
-
There was a problem hiding this comment.
diff --git a/src/config/loadGitHubOrgsFromEnvironment.ts b/src/config/loadGitHubOrgsFromEnvironment.ts
index 6a51857..6014d26 100644
--- a/src/config/loadGitHubOrgsFromEnvironment.ts
+++ b/src/config/loadGitHubOrgsFromEnvironment.ts
@@ -1,7 +1,7 @@
import { GitHubOrgConfig } from '@/types';
// Don't use '@api' here, because it's ... not loaded yet, or something?
-import { GitHubOrg } from '../api/github/org';
+import { GitHubOrg } from '@api/github/org';
// Configs - loosely typed and ephemeral, used for collecting values found in
// the environment. We check for missing values using this but not for types,
hubertdeng123
approved these changes
Jul 21, 2023
chadwhitacre
force-pushed
the
cwlw/app-org
branch
2 times, most recently
from
cd7b1a1 to
e69dc6f
Compare
chadwhitacre
force-pushed
the
cwlw/factor-out-org
branch
from
a635bed to
aa44c03
Compare
chadwhitacre
force-pushed
the
cwlw/factor-out-org
branch
from
aa44c03 to
17e4d89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #482, after #531.
I want to see if I can move the functions from
githubEventHelpersonto this class, to unfrobulate the call chains and how we pass org around.