Move sendQuery to GitHubOrg.sendGraphQuery #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2023
chadwhitacre
force-pushed
the
cwlw/org-api
branch
from
63c26fe to
84b2f3e
Compare
chadwhitacre
force-pushed
the
cwlw/send-graph-query
branch
from
6ab030a to
21d8404
Compare
hubertdeng123
approved these changes
Jul 24, 2023
chadwhitacre
force-pushed
the
cwlw/org-api
branch
from
be009fb to
84b2f3e
Compare
chadwhitacre
force-pushed
the
cwlw/send-graph-query
branch
from
21d8404 to
45eec59
Compare
chadwhitacre
force-pushed
the
cwlw/send-graph-query
branch
from
45eec59 to
596c22f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
=======================================
Coverage 84.64% 84.65%
=======================================
Files 100 100
Lines 2514 2515 +1
Branches 481 481
=======================================
+ Hits 2128 2129 +1
Misses 379 379
Partials 7 7
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #482, after #537.
I want to encapsulate the helpers under the GitHubOrg class for cleanliness and assurance that we're not crossing org wires. This is the root helper function and so is a good candidate to go first.