Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Danger - recognize PR links based on full URL instead of just the PR number. #68

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Jan 25, 2024

This was an issue with there was another link in the changelog that had the same number as the current PR.

Reported by @romtsn on Discord

e.g. I've opened a new PR with id 643 https://github.com/getsentry/sentry-android-gradle-plugin/blob/fed6ae5645b62abbeea32354b74d623e01b7294c/CHANGELOG.md?plain=1#L10, but there's already an entry #643 which references the sentry-java repo and hence it fails https://github.com/getsentry/sentry-android-gradle-plugin/blob/fed6ae5645b62abbeea32354b74d623e01b7294c/CHANGELOG.md?plain=1#L447

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks! I'm not sure if we use this action in the repos where we do not include the PR link into the changelog entry (like sentry-javascript), but for us it works!

@romtsn
Copy link
Member

romtsn commented Jan 25, 2024

yeah, won't work for sentry-wizard for example https://github.com/getsentry/sentry-wizard/blob/master/CHANGELOG.md

@vaind
Copy link
Collaborator Author

vaind commented Jan 25, 2024

yeah, won't work for sentry-wizard for example getsentry/sentry-wizard@master/CHANGELOG.md

thanks for pointing that out, I'll make it work in both cases

@vaind vaind force-pushed the fix-pr-link-recognition branch from 5f4af83 to 4510852 Compare January 25, 2024 13:13
danger/dangerfile.js Fixed Show fixed Hide fixed
danger/dangerfile.js Fixed Show fixed Hide fixed
@vaind vaind merged commit 2c3ced6 into main Jan 25, 2024
16 checks passed
@vaind vaind deleted the fix-pr-link-recognition branch January 25, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants