feat(protocol): Add jvm debug file type
#2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
commented
Apr 4, 2023
| /// The number of milliseconds Sentry spent resolving sources for a java event. | ||
| /// | ||
| /// This metric is measured in Sentry and reported in the java processing task. | ||
| #[metastructure(field = "ms.processing.jvmbased")] |
There was a problem hiding this comment.
Not sure, this is needed.
adinauer
changed the title
jvmbasedjvmbased debug file type
jjbayer
approved these changes
Apr 7, 2023
| @@ -486,6 +508,8 @@ pub enum DebugImage { | |||
| Wasm(Box<NativeDebugImage>), | |||
| /// Source map debug image. | |||
| SourceMap(Box<SourceMapDebugImage>), | |||
| /// JVM based debug image. | |||
| JvmBased(Box<JvmBasedDebugImage>), | |||
There was a problem hiding this comment.
I would rename JvmBased to Jvm everywhere, but that is just a personal preference.
There was a problem hiding this comment.
Yeah agreed, this also came up in another PR. Will rename it and update this PR.
iker-barriocanal
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
LGTM. Please update the PR title to match the commit message format.
Co-authored-by: Iker Barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
adinauer
changed the title
jvm debug file typejvm debug file type
antonpirker
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Java Source Context we add a new debug file type called
jvm. More info on it can be found in getsentry/sentry-java#633 (comment)