feat(spans): Extract trace context status for indexed spans #3407
Conversation
| @@ -39,6 +39,7 @@ expression: "(&event.value().unwrap().spans, metrics)" | |||
| "release": "1.2.3", | |||
| "sdk.name": "sentry.javascript.react-native", | |||
| "sdk.version": "unknown", | |||
| "trace.status": "unknown", | |||
There was a problem hiding this comment.
Where does this unknown come from and is that something we want?
There was a problem hiding this comment.
This ^. The code LGTM, but according to dev docs, unknown means:
An unknown error raised by APIs that don't return enough error information
And trace.status:
Optional. Whether the trace failed or succeeded.
There was a problem hiding this comment.
We coalesce this tag to unknown if theres no trace status supplied. I think we do want this since unknown is a valid value for trace.status and it matches the intended usage to me.
I'll use this for now and we can update this later if needed.
| @@ -39,6 +39,7 @@ expression: "(&event.value().unwrap().spans, metrics)" | |||
| "release": "1.2.3", | |||
| "sdk.name": "sentry.javascript.react-native", | |||
| "sdk.version": "unknown", | |||
| "trace.status": "unknown", | |||
There was a problem hiding this comment.
This ^. The code LGTM, but according to dev docs, unknown means:
An unknown error raised by APIs that don't return enough error information
And trace.status:
Optional. Whether the trace failed or succeeded.
Fixes a broken snapshot test, from #3407, due to merging to master without pulling latest snapshot changes. #skip-changelog
Extract trace context
statusfor indexed spans. To be used in the queues module so we can see the status of tasks.#skip-changelog