-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(spans): Do not trim essential fields #3670
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
fix(spans): Do not trim trace ID
fix(spans): Do not trim essential fields
Jun 4, 2024
Dav1dde
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a
Dav1dde
approved these changes
Jun 4, 2024
jjbayer
added a commit
that referenced
this pull request
Jun 5, 2024
Follow-up to #3670: Also stop trimming span timestamps.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #3645, we're seeing incomplete or missing trace IDs on spans (see linked sentry issues). What happens is that after visiting a long
span.description
, there is no budget left for essential fields and the trimming processor drops or trims them.trim = "false"
field attribute to disallow trimming of specific fields.span.trace_id
and other essential fields to prevent them from being partially scrubbed or dropped entirely.Current limitations:
trim = "false"
are limited in size (which they are currently not, see ref(protocol): RepresentSpanId
andTraceId
as bytes #3535 as follow-up).trim = "false"
fields before trimming any other fields.Fixes RELAY-2NY7, RELAY-2NY8, SNUBA-552.