fix(metrics): remove Redis spans from Queries insights module #3795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis spans were intended to be filtered out of the Queries insights module, since it currently only supports SQL. This used to work via a check for
*redis*
in the span op. With the JS SDK's v8 release the span op for redis spans became simplydb
and Redis spans starting showing up in the Queries module.JS v8 follows the OTel standard of setting the
db.system
attribute to"redis"
, so we can use that as a secondary check to bring back the expected filtering.