ref(metrics): Remove option for controlling metrics summaries calculation #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Jul 8, 2024
Comment on lines
-217
to
-223
| /// Overall sampling of metrics summaries computation. | ||
| #[serde( | ||
| rename = "relay.compute-metrics-summaries.sample-rate", | ||
| deserialize_with = "default_on_error", | ||
| skip_serializing_if = "is_default" | ||
| )] | ||
| pub compute_metrics_summaries_sample_rate: Option<f32>, |
There was a problem hiding this comment.
Do we need to keep forwarding this option to external relays so they keep computing the summary? Or is this option so new that we don't care?
There was a problem hiding this comment.
Discussed offline, this was only enabled for our own org so it can be removed.
jjbayer
approved these changes
Jul 8, 2024
Comment on lines
-217
to
-223
| /// Overall sampling of metrics summaries computation. | ||
| #[serde( | ||
| rename = "relay.compute-metrics-summaries.sample-rate", | ||
| deserialize_with = "default_on_error", | ||
| skip_serializing_if = "is_default" | ||
| )] | ||
| pub compute_metrics_summaries_sample_rate: Option<f32>, |
There was a problem hiding this comment.
Discussed offline, this was only enabled for our own org so it can be removed.
Dav1dde
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an option for controlling metrics summaries calculation, since it's not needed anymore.
#skip-changelog