fix(profiling): Only transfer valid profile ids #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was transfering the profile id onto the transaction all the time which is not desirable since we need to fully validate the profile first.
Dav1dde
approved these changes
Jul 11, 2024
jjbayer
requested changes
Jul 11, 2024
There was a problem hiding this comment.
We transfer the profile ID into the event before dynamic sampling to enable a specific dynamic sampling bias, see #2710.
If this dynamic sampling behavior is no longer needed, we can go ahead with the PR and integrate the transfer into profile::process as David suggested.
|
@jjbayer Ahh I wasn't aware of that. The issue I'm trying to address here is that by transferring the profile id before processing the profile, it's possible that the profile is invalid and references should be removed from the transaction as well. I've updated the PR to transfer the profile id twice. Once for dynamic sampling, and once after the processing to handle this. Are there any issues with this? |
jjbayer
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was transfering the profile id onto the transaction all the time which is not desirable since we need to fully validate the profile first.