Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): Serialize the DSC into event payloads #3811

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jul 11, 2024

Serializes the full contents of the dynamic sampling context (DSC) into the
event payload as a hidden _dsc field. This allows for debugging of dynamic
sampling rules, sample rates, and all information passed along by SDKs.

This runs exclusively in processing Relays at the very end of the processing
stage. Note that this may include inferred DSCs from the event payload under
any of the following conditions:

  • The client did not send a DSC
  • The DSC originates from a different Sentry organization

Ref https://github.com/getsentry/team-ingest/issues/372

Follow-up:

  • Mark inferred DSCs

@jan-auer jan-auer self-assigned this Jul 11, 2024
@cleptric
Copy link
Member

Can we mark inferred contexts somehow?

@jan-auer
Copy link
Member Author

Can we mark inferred contexts somehow?

Great suggestion, I'm collecting this as follow-up.

@jan-auer jan-auer marked this pull request as ready for review July 11, 2024 12:46
@jan-auer jan-auer requested a review from a team as a code owner July 11, 2024 12:46
@jan-auer jan-auer requested a review from jjbayer July 11, 2024 13:04
@jan-auer jan-auer merged commit bae3dc0 into master Jul 11, 2024
23 checks passed
@jan-auer jan-auer deleted the feat/serialize-dsc branch July 11, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants