ref(metrics): Make metrics aggregator health check sync #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
changed the title
Dav1dde
force-pushed
the
dav1d/agg-health2
branch
from
de417cc
to
d68a3f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the health check sync, it occassionally times out due to metric flushes taking longer than the threshold, this is generally not a problem and small short backlogs in the aggregator are expected (due to the flushes), the health checks shouldn't be failing because of it.
The health check itself is very useful though, we should not be ready if the aggregator would reject metrics.
Re-Create of #3894
#skip-changelog