fix(metrics): Extract set span metrics from numeric values #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
approved these changes
Aug 5, 2024
vgrozdanic
approved these changes
Aug 5, 2024
vgrozdanic
reviewed
Aug 5, 2024
Comment on lines
+170
to
+175
| MetricType::Set => BucketValue::set_from_str(&match instance.get_value(field?)? { | ||
| Val::I64(num) => Cow::Owned(num.to_string()), | ||
| Val::U64(num) => Cow::Owned(num.to_string()), | ||
| Val::String(s) => Cow::Borrowed(s), | ||
| _ => return None, | ||
| }), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numbers in the data couldn't be used as sets. This came up as an issue when configuring metric extraction rules, especially since setting a number as a tag would implicitly convert the value to a string and make the set work. Adds the extraction for numbers as well, but convert them to a string first, this allows for consistent sets across tags and data as well better behaviour for users.