Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): extract country code into spans #3911

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Aug 8, 2024

work towards getsentry/sentry#75230

This PR adds country_code as an indexed span tag. Eventually we would like to create regional metrics, but we have to make a product decision on whether we want country based metrics, or larger region metrics (ex. continent). There are also ~200 countries, which could be high cardinality wise, but at least we have a known limit (lmk if you have thoughts on this!)

@DominikB2014 DominikB2014 marked this pull request as ready for review August 8, 2024 15:12
@DominikB2014 DominikB2014 requested a review from a team as a code owner August 8, 2024 15:12
@Dav1dde
Copy link
Member

Dav1dde commented Aug 8, 2024

We've tried in the past to get rid of the country code as a span attribute, iirc there were discussions with @k-fish and slowly moving it to on demand.

For frontend heavy and globally operating orgs the country code accounts for 80% of the total cardinality observed.

This was the tracking issue.

@DominikB2014
Copy link
Contributor Author

DominikB2014 commented Aug 8, 2024

For frontend heavy and globally operating orgs the country code accounts for 80% of the total cardinality observed.

@Dav1dde thanks for that insight! so it sounds like your suggesting to avoid tagging metrics by country code directly, and it would be preferred to group by some larger region, perhaps continent. But we can still keep country_code in indexed data for sample.

@Dav1dde
Copy link
Member

Dav1dde commented Aug 8, 2024

Probably better to tag by geographical region, but obviously that may not be good enough for the product experience.

@DominikB2014 DominikB2014 enabled auto-merge (squash) August 8, 2024 17:39
@DominikB2014 DominikB2014 merged commit 70c15da into master Aug 8, 2024
24 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/extract-country-code branch August 8, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants