Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statsd): manually revert envelope item metrics #4358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(statsd): manually revert envelope item metrics #4358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions relay-server/src/endpoints/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,16 +404,6 @@ fn emit_envelope_metrics(envelope: &Envelope) {
histogram(RelayHistograms::EnvelopeItemSize) = item.payload().len() as u64,
item_type = item.ty().name()
);
metric!(
counter(RelayCounters::EnvelopeItems) += 1,
item_type = item.ty().name(),
sdk = client_name.name(),
);
metric!(
counter(RelayCounters::EnvelopeItemBytes) += item.payload().len() as u64,
item_type = item.ty().name(),
sdk = client_name.name(),
);
}

if has_transaction && has_attachment {
Expand Down
6 changes: 0 additions & 6 deletions relay-server/src/statsd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,10 +642,6 @@ pub enum RelayCounters {
/// - `handling`: Either `"success"` if the envelope was handled correctly, or `"failure"` if
/// there was an error or bug.
EnvelopeRejected,
/// Number of items we processed per envelope.
EnvelopeItems,
/// Number of bytes we processed per envelope item.
EnvelopeItemBytes,
/// Number of transactions with attachments seen in the request handler.
TransactionsWithAttachments,
/// Number of envelopes that were returned to the envelope buffer by the project cache.
Expand Down Expand Up @@ -842,9 +838,7 @@ impl CounterMetric for RelayCounters {
RelayCounters::EventCorrupted => "event.corrupted",
RelayCounters::EnvelopeAccepted => "event.accepted",
RelayCounters::EnvelopeRejected => "event.rejected",
RelayCounters::EnvelopeItems => "event.items",
RelayCounters::TransactionsWithAttachments => "transactions_with_attachments",
RelayCounters::EnvelopeItemBytes => "event.item_bytes",
RelayCounters::BufferEnvelopesReturned => "buffer.envelopes_returned",
RelayCounters::BufferTryPop => "buffer.try_pop",
RelayCounters::BufferSpooledEnvelopes => "buffer.spooled_envelopes",
Expand Down
Loading