fix(pii): Scrub user fields in span.sentry_tags #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Dec 10, 2024
| @@ -1183,7 +1183,7 @@ def test_span_ingestion_with_performance_scores( | |||
| "data": { | |||
| "transaction": "/page/with/click/interaction/jane/123", | |||
| "replay_id": "8477286c8e5148b386b71ade38374d58", | |||
| "user": "admin@sentry.io", | |||
| "user": "[email]", | |||
There was a problem hiding this comment.
This is now scrubbed by default, just like the top level event.user.email.
| /// A list of supported span tags for tag extraction. | ||
| #[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)] | ||
| #[allow(missing_docs)] | ||
| pub enum SpanTagKey { |
There was a problem hiding this comment.
Instead of storing a BTreeMap<SpanTagKey, Annotated<String>>, we now have a SentryTags struct.
AbhiPrasad
approved these changes
Dec 10, 2024
jan-auer
approved these changes
Dec 10, 2024
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User fields are transferred into
span.sentry_tagsbefore PII scrubbing. Most user fields are marked aspii = true, that is, they should be scrubbed by default.This PR
sentry_tagsinto a special typeSentryTags, such that we can mark specific tags aspii = true,sentry_tags.user_ipto the builtin PII selector for IP scrubbing.