fix(doc): Avoid unnecessary line-wrapping in schema docs #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
Jul 31, 2020
| @@ -22,7 +22,7 @@ lru = "0.4.0" | |||
| parking_lot = "0.10.0" | |||
| regex = "1.3.9" | |||
| sentry-types = "0.14.1" | |||
| schemars = { version = "0.7.1", features = ["uuid", "chrono"], optional = true } | |||
| schemars = { version = "0.8.0-alpha-4", git = "https://github.com/untitaker/schemars", branch = "preserve-formatting", features = ["uuid", "chrono"], optional = true } | |||
There was a problem hiding this comment.
I'm wondering if it would make sense to re-export schemars as a module of relay-common, just like we do with uuid and some others. Given that we need it to be absolutely compatible across the crates, I think that would make sense.
There was a problem hiding this comment.
Yeah was wondering how to do that. One problem is schemars_derive which I am not sure how to reexport.
There was a problem hiding this comment.
It does fail to compile very spectacularly if there's a version split though, so that's good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schemars does some funny text processing that destroys our beautiful hand-crafted markdown. Fork that dependency, add option to disable the behavior and use it here.
GREsau/schemars#45