ensure that the socket is closed

CHANGES

@@ -3,6 +3,7 @@
 
 * Reintroduced overloads for better typing in `CallList`.
 * Added typing to `Call` attributes.
+* Close unclosed socket (see #689)
 
 
 0.24.0

responses/__init__.py

@@ -532,9 +532,6 @@ def _form_response(
     headers: Optional[Mapping[str, str]],
     status: int,
 ) -> HTTPResponse:
-    with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as dummy_socket:
-        orig_response = http.client.HTTPResponse(sock=dummy_socket)
-
     """
     The cookie handling functionality of the `requests` library relies on the response object
     having an original response object with the headers stored in the `msg` attribute.
@@ -544,16 +541,18 @@ def _form_response(
     introduce potential errors.
     Therefore, we intentionally ignore type checking for this assignment.
     """
-    orig_response.msg = headers  # type: ignore[assignment]
-
-    return HTTPResponse(
-        status=status,
-        reason=client.responses.get(status, None),
-        body=body,
-        headers=headers,
-        original_response=orig_response,
-        preload_content=False,
-    )
+    with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as dummy_socket:
+        with http.client.HTTPResponse(sock=dummy_socket) as orig_response:
+            orig_response.msg = headers  # type: ignore[assignment]
+
+            return HTTPResponse(
+                status=status,
+                reason=client.responses.get(status, None),
+                body=body,
+                headers=headers,
+                original_response=orig_response,
+                preload_content=False,
+            )
 
 
 class Response(BaseResponse):