Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements and refactor #155

Merged
merged 7 commits into from
Jul 25, 2017
Merged

Various improvements and refactor #155

merged 7 commits into from
Jul 25, 2017

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jul 25, 2017 •
edited
Loading 

responses.add(Response('GET', 'http://example.com'))

@dcramer dcramer force-pushed the ref/cleanup-matches branch 2 times, most recently from 2c70eb3 to 5108588 Compare July 25, 2017 20:45
@dcramer
Copy link
Member Author

dcramer commented Jul 25, 2017

Putting this up for feedback at a first pass in cleaning up the way you register matches. This makes it a lot more flexible and gets us to the point where you could do more dynamic fixtures.

@dcramer dcramer changed the title Add Response match interface Various improvements and refactor Jul 25, 2017
@dcramer dcramer mentioned this pull request Jul 25, 2017
Closed
@dcramer dcramer merged commit 91019d6 into master Jul 25, 2017
@dcramer dcramer deleted the ref/cleanup-matches branch July 25, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dcramer