Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom exception to be able to attach request to an attribute #608

Closed
wants to merge 1 commit into from

Conversation

mgaligniana
Copy link
Contributor

@mgaligniana mgaligniana commented Dec 6, 2022

Hello!

This PR applies the Maksim Beliaev's suggest about:

[...] should we consider attaching an attribute to a custom exception?

in ticket #588

I'm not sure if these were the changes expected, let me know any change/test/doc required!

I appreciate any feedback, thank you so much!

@mgaligniana mgaligniana marked this pull request as ready for review December 6, 2022 16:15
Copy link
Collaborator

@beliaev-maksim beliaev-maksim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR breaks backwards compatibility. We should not raise own exception but raise instead one that user has provided in the constructor.

@beliaev-maksim
Copy link
Collaborator

implemented in #614

@mgaligniana
Copy link
Contributor Author

this PR breaks backwards compatibility. We should not raise own exception but raise instead one that user has provided in the constructor.

Makes sense! Thank you!

Sorry if I'm late, I was about to update my pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants