Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Add Sentry license and readme #18

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 19, 2023

This PR replaces the original rrweb license with our Sentry license. Furthermore, it adjusts the readme to inform about the purpose of this fork and to give attribution to the original authors.

cc @chadwhitacre

ref #15

LICENSE Outdated Show resolved Hide resolved
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Lms24 Lms24 merged commit 4087370 into publish-fork Jan 19, 2023
@Lms24 Lms24 deleted the lms-publish-license-readme branch January 19, 2023 17:48
Lms24 added a commit that referenced this pull request Jan 23, 2023
Replace the original rrweb license with our Sentry license.
Adjust the readme to inform about the purpose of this
fork and to give attribution to the original authors.
Lms24 added a commit that referenced this pull request Jul 6, 2023
While setting up the publishing process for our `rrweb` fork, we changed
the `LICENSE` text (#18) to our standard MIT license. This was recently
pointed out in rrweb-io#1248. While It's
worth noting that our fork was also always MIT-licensed, we did changed
the copyright, which incorrectly suggested that the repo's code was
ours. While I'm not entirely sure what the reason for the change was
back then, in hindsight this shouldn't have happened and I'm sorry for
causing any confusion associated with this change.

This patch adjusts the `LICENSE` file to include both, rrweb's original
license as well as our license text, which is what we settled on after
internal conversations (see
#91 (comment)).

---------

Co-authored-by: Chad Whitacre <chad@zetaweb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants