Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .idea to .gitignore #1803

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Add .idea to .gitignore #1803

merged 2 commits into from
Nov 18, 2022

Conversation

spawnia
Copy link
Contributor

@spawnia spawnia commented Nov 10, 2022

Just like .vscode/tags, it is unnecessary IDE stuff.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@emmatyping
Copy link
Contributor

/gcbrun

1 similar comment
@hubertdeng123
Copy link
Member

/gcbrun

@hubertdeng123
Copy link
Member

Seems like our pr check is failing on builds from outside contributors, I'll need to take a look into this

@hubertdeng123
Copy link
Member

/gcbrun

@hubertdeng123
Copy link
Member

@spawnia could you merge master in here? That should fix the failing test

@hubertdeng123
Copy link
Member

/gcbrun

1 similar comment
@hubertdeng123
Copy link
Member

/gcbrun

@hubertdeng123
Copy link
Member

oh, interesting how since your root directory is sentry-self-hosted the test breaks, since it isn't self-hosted

@spawnia
Copy link
Contributor Author

spawnia commented Nov 17, 2022

oh, interesting how since your root directory is sentry-self-hosted the test breaks, since it isn't self-hosted

Good discovery, I would not know how to fix it though.

@hubertdeng123
Copy link
Member

going to merge this because CI here should succeed, root directory is of a different name

@hubertdeng123 hubertdeng123 merged commit 144fd37 into getsentry:master Nov 18, 2022
@spawnia spawnia deleted the ignore-idea branch November 22, 2022 11:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants